Weekly Firo Development Meeting Minutes

Development
48

Week 4 November

Lelantus Spark

  • Levon worked on testing and bug fixes. Everything seems to be working on Levon’s side.
  • Limits to be entered into devnet. Numbers will be posted to get approval before inputting it
  • Devnet is planned to start the following day.
  • Mobile: Levon started on the mobile code for lib and server API for easy implementation for 3rd party mobile wallet. It will be tested and finalized this week

InstantSent Lock

  • Peter has finished the PR for allowing whitelist of transactions done by the InstantSend Lock
  • A special branch was created to run on long-running masternodes to get the list of UTOXs involved in the InstantSend lock
  • Some of these lost transactions are not very old but are problematic. This is most likely due to the transactions being dropped from the mempool
  • Suggest creating a watchdogto lookout for transactions that are not mined after a certain time (eg. 24 hours) and automatically dump from the mempool. This improves the integrity of the network. When a transaction is dumped, it is to be saved so that it can be rebroadcast later.
  • To limit whitelist to only the really old transactions first
  • The hardfork for the InstantSend fix will be set by time instead of block number

Tx Creation bug

  • Gevorg and Sproxet are assisting on the issue. Sproxet finishing up on the Tx creation bug and syncing up with Peter.

Firo-Client

  • Sproxet is looking at the masternode locking issue and further improving the coin control mechanism.

Miscellaneous

  • Firo-QT: Gevorg completed UI fixes for the Ubuntu side with the small resolution. There is more work to be done on other tabs. (Restoration and Lelantus tabs)
  • Electrum-Firo: Gevorgfixed the build procedure for Anwar to test.
  • FiroDEX: Preparing version 0.5.7
  • Spork extension PR is issued
  • There will be hardforks for Spork and InstantSend fix each
2 Likes
49

December 2022

Week 1 December

Lelantus Spark

  • Levon is working on wallet crashing bug during rescanning
  • Spark limits
    • Spend (unshield) limit per transaction 10k FIRO
    • Spend (unshield) limit per block 20k FIRO
    • Spend input limit per tx 50
    • Spend input limit per block
    • Shielded output number limit per tx 16
  • Levon finished libspark for mobile and is almost finished with the Spark mobile API. Documentation will be prepared for the mobile API and mobile backend. Documentation will also be prepared for the libspark API to make mobile implementation easier
  • Peter did code reviews and is preparing for the devnet launch this week

InstantSend Lock

  • Peter is preparing unit test for it

Firo-Client

  • Sproxet is working on a light client support for firo-client
  • Sproxet found the bug found regarding the masternode lock issue in Firo client and will be fixing it.

Miscellaneous

  • FiroDEX: Anwar tested all the swaps and appears working. There are issues with BNB withdrawal which gives an invalid address. A new version can be released soon.
  • Ledger-Live: Firo integrations currently works. Levon will review and can be tested internally
  • Electrum-Firo: Gevorg has finished the build procedure.
  • Gevorg to push changes to hideRAP address at the QTrestoration screen

Week 2 December

Lelantus Spark

  • Peter and Levon started testing devnet, Several mints and spends were created and works well so far.
  • Levon finished with the mobile library and api calls. This requires a new github repo. Will also prepare documentation. It is similar to Lelantus and should be easy to implement
  • Levon took a look at PR created by Aaron and merged it into the Spark working branch. 2-3 comments are yet to be resolved. Other than that everything looks fine.

Instantsend Lock

  • Peter to finalize testing

Firo Client

  • For light client support, Sproxet abstracts firod interaction in firod-client.It is progressing smoothly

Miscellaneous

  • Firo: Gevorg finished transaction creation issue and tested on regtest. Found that issue was caused by the size of the transaction. Limit the maximum size of the tx you can create so that you will not create a tx that cannot be accepted by the mempool. Changes will be made to increase the mempool limit & transaction creation code.
  • Firo-QT: Gevorg completed UI problems for Ubuntu but might crash on other OS. A Windows build will be made for testing.
  • Electrum-Firo: Enabled dependabot for dependencies repo.
  • FiroDEX: Investigating issues for v0.5.7
  • Ledger-live: To try finalizing with ledger

Week 3 December

Lelantus Spark

  • Peter and Levon continue monitoring and testing devnet. Spark’s second iteration is used in testing. Spark code cleanup and bug fixes were done too
  • Mobile: Levon did the mobile library and API code for Spark. The documentation for mobile implementation was done.
  • An Explorer for Spark devnet will be needed. There will be 3 types of explorers that needs to be updatedfor Spark
    • Blockbook
    • Bitcore
    • Insight

InstantSend Lock

  • Peter did some testing on InstantSend lock issues, but there were some tests that are failing. Additional unit tests and fixes are to be done, expected within a day.

Firo Client

  • Sproxet worked on the extraction of daemon code in Firo client for light client support
    • Estimation of completion extraction of code: Couple of weeks
    • Estimation of completion light client support: Additional month

Miscellaneous

  • Ledger-live: Gevorg worked on the Firo integration in ledger UI fixes and finalized with ledger
  • FiroDEX: Gevorg fixed linux build for 0.5.7 version. The coin configuration is being worked on.
  • Firo-qt: Gevorg finished the UI problems for Ubuntu, but found out that it broke coin control functionality. It’s not hard to fix it. He will push UI fixes with coin control fixes.

Week 4 December

Text update from dev team as most are on holiday

Lelantus spark

  • There were some bugs due to some corner case and being investigated.
  • Mobile: Levon worked on spark mobile stuff

InstantSend Lock

  • Peter continue to solve the InstantSend issue

Miscellaneous

  • Firo-Qt: Gevorg finished UI for small resolution display
  • FiroDEX: Gevorg almost finished coin config for v0.5.7
  • Electrum-firo: Gevorg checked and tested Dependabot updates for deprecated dependencies
  • Ledger live: works on Firo integration in ledger are still ongoing
2 Likes
50

January 2023

Week 1 January

Getbalance issue

  • Peter is investigating the get balance issue. The issue is the wallet doesn’t allow one to spend funds sometimes. This happens on a really old wallet that was before HD and Mnemonics. There is a dirty fix available but not recommended unless funds are urgently needed.

Lelantus Spark

  • Levon is working on the deadlock issue. This is probably related to devnet explorer crashing.

InstantSend Lock

  • On hold until getbalance issue is solved

Firo Client

  • Sproxet getting work done for light client and updated firo client dependencies (3 years out of date)

Miscellaneous

  • Electrum-Firo: Gevorg checked and tested Dependabot updates
  • Ledger-live: Finalize with ledger
  • FiroDEX: Finalized preparation for new version for release
  • Ubuntu UI: New issue of unable to resize window due to sigma stuff is in the way. Gevorg is working on trying to remove Sigma window from the UI

Week 2 January

Getbalance issue

  • Peter was able to reproduce but there were some kind of issues. Not sure if the reproduced issue is the one that mining pools are encountering. He suspects the main problem is non-HD wallet and its restoration. Trying to repro on regtest, no luck so far. Levon will be assisting however he can

Lelantus Spark

  • Levon continues on the deadlock issue. The issue was found and a fix is working so far. Further testing is still needed.
  • Few python tests and several C++ unit tests were added
  • Works on Spark mobile are still ongoing

Miscellaneous

  • Electrum-firo: Gevorg update python version to 3.8 as there were some problems with dependency on 3.6 when building electrum-firo
  • FiroDEX: Gevorg added local config files and will release new version after testing
  • firo-qt: Gevorg is finishing work on removing sigma dialog from UI. There are some deprecated signals that need to be removed.
  • Ledger-live: Work on Ledger and to be finalized this week.

Week 3 January

Firo

  • Hardfork regarding the extension of Lelantus emergency switch per community decision went smoothly
  • Peter monitored the hardfork transition. There are some nodes that have not been updated. It will be fine as there are no active sporks currently but if they update they will need to reindex
  • There are some performance issues when syncing with wallets that have huge transaction history. To test by starting the wallet with firod (instead of firoqt) when it hasn’t synced for quite awhile. It might be something to do with GUI part of transaction list.

Getbalance issue

  • There are discrepancy between “getbalance” and “getbalance *” RPC calls that are giving incorrect results. Peter did some investigation on testnet and was able to kind of reproduce the results. He suspects the problem is because the wallet is non-HD. Logs were taken from the reindex and UTXO list processed during these calls and analyzed. Hopefully a fix will be found soon.

Lelantus Spark

  • Levon is finished with mobile spark related stuff
  • Deadlock fix is also finished and levon will be doing a cleanup. After that he is to set up explorer for devnet and start with the UI backend implementation.

Miscellaneous

  • Electrum Firo: Gevorg is trying to fix a bug when creating an exe file for Windows. The fix is mostly done but has problems with naming and version. It will be fixed soon
  • Firo-QT: Gevorg finished removing sigma dialog from the UI. He reworked some Lelantus dialog box and will make ui smaller by 100px if approved
  • Ledger: to finalized ledger
  • FiroDEX: Some changes has been made but not yet tested

Week 4 January

Text update from dev team as some devs were unwell to attend meeting

Getbalance issue

  • Peter did a test for UTXOs in the wallet (if they are treated as “ours”) on regtest (non-HD wallet) and testnet (HD wallet). There is one issue and was able to repro it on testnet and a fix is underway.

Lelantus Spark

  • Levon is fixing failing unit test
  • Levon researched Spark explorer and implementation method

Miscellaneous

  • Electrum-Firo: Gevorg worked on electrum-firo build fix
  • Firo-QT: Gevorg is removing sigma dialog from UI and to finalized this week

Week 5 January

Getbalance issue

  • Peter received the wallet from 2miners and found that listed UTXOs that are treated by spendable by getbalance without paramaters and getbalance with * parameters.
  • There are discrepancies between those RPC outputs. He is investigating why this is happening and knowing what might be wrong. Testing has started but a huge wallet is taking 4 to 5 hours to go through. He is optimistic on finding the reason and a fix should be easy if right
  • There might be another problem which was found on testnet with a huge wallet.

Lelantus Spark

  • Levon started working on Devnet explorer implementation and spent most of the time familiarizing with explorer code. Estimated that it will be ready some time this week
  • Levon also investigate failing test on various platform

Firo Mobile

  • There were recovery issues on the Firo mobile wallet that was reported. Upon processing the recovery step 3 out of 5 (downloading set data) the app crashes to the home screen.
  • Levon is currently prioritizing this issue and investigating it

Miscellaneous

  • Electrum-Firo: Gevorg worked on Electrum Firo build fix but ran into some problems with BLS. To solve the issue, python needs to be downgraded to version 3.8. Levon is assisting with this.
  • Firo-QT: Levon reviewed Gevorg changes on removing the sigma UI cleanup
  • A new staff, Narek, joins the meeting for the first time, he has been helping Levon with Spark
2 Likes
51

February 2023

Week 1 Febuary

Getbalance issue

  • Peter found a bug. getbalance returns same output with and without “*”. The balance now works but spending is not possible yet. He is able to reproduce the issue on regtest with a non-HD wallet. Coinbase, reindex and rescan wallet, bugs will appear.

Lelantus Spark

  • Levon added several unit test and writing small documentation for Lelantus Spark flow
  • Levon continues with spark devnet explorer and other parts of Lelantus spark

Firo Mobile

  • Levon is investigating lost funds and trying to restore funds to send to the user. He is trying to identify the reason for the issue. His theory is it seems skipping a lot of mintpool elements leaves some huge gap from one Mint to another, compared to QT/Electron. Further investigation is ongoing.

Miscellaneous

  • Electrum-Firo: Gevorg finished the build, there are some problems during startup (X11) and will fix it soon. He will try to add build procedure with Github Actions
  • FiroDEX: A new version is being prepared
  • Ledger: Works on Ledger implementation is underway
  • Electrum-Firo: To bump version from 4.1.5.1 to 4.1.5.2
  • Reuben to start talking to geometry labs for additional assistance with lite wallet implementation
6 Likes
52

Week 2 February 2023

Getbalance issue

  • Peter has mostly got the grasp of the bug. For the issue to occur, the wallet has to be a non-HD wallet. can create a send with a protected wallet by using some dirty fixes, but a proper fix is still in the works.
  • There is another bug that manifests itself where getbalance amounts are reversed (asterisk vs. without asterisk). This is being investigated and tested.

Lelantus Spark

  • Levon added more unit test and finalizing Spark devnet explorer
  • Spark Mobile: API and library are being finalized

Firo Mobile

  • Levon is investigating a mobile lost funds issue. There is 1 case of duplicated serial numbers of mints which makes some parts of users’ funds unspendable.

Miscellaneous

  • Electrum-Firo: Gevorg pushed the PR and will discuss with Anwar regarding the script to update dependencies.
  • FiroDex: Gevorg is finalizing FiroDex
4 Likes
53

Week 3 February 2023

Lelantus Spark

  • Levon was cleaning up and fixing some bugs on unit tests.
  • Levon is finalizing the implementation of Spark support for Explorer.
  • There are some tests and preparation before launching the testnet.
  • Mobile Spark:
    • Levon finalizing everything related to mobile APIs. There are some minor improvements to be made to lib code for mobile. The documentation for mobile implementation is being prepared.
  • To support Spark RPC calls, some changes must be made to electurmx.

Bug: wallet not displaying transactions

  • Peter found the cause of the wallet problem because it got corrupted. Transactions are missing from non-HD wallet.dat. During a rescan, somehow the wallet tx was not rescanned and put into the wallet. To recover the transactions for this wallet using the private key and public addresses of blockchain data to create a new wallet and spend from that (short term fix)

Firo

  • Peter will be trying to figure out how to fix the wallet scanning code to avoid any issues in the future.

Miscellaneous

  • Electrum-Firo: Gevorg finally finished with the build process and it works well. There are problems with the macOS packaging, but it will be fixed in a few hours. The Windows and Linux versions worked well. PR that supports Ledger Nano S Plus will need to be merged to support it.
  • FiroDex: Gevorg is almost finished with it.
5 Likes
54

Week 4 February 2023

Lelantus Spark

  • Levon is working on testing and fixing mobile_api and mobile_lib. Mobile_api branch was merged for Lelantus and working.
  • There were additional tests done on regtest, and more unit tests were added.
  • Cleanup of the mobile documentation for mobile_api and lib was done to ensure presentability for light wallet implementation, etc.

Getbalance () bug

  • Peter finally found the cause of the bug. How the bug occurs goes back to an issue where a transaction is created but not accepted into the mempool. The transaction is still saved to the wallet, which means the wallet thinks the transaction is created and the UTXOs used to create this transaction are spent. This in fact decreases the wallet balance, which is why the problem occurs.
  • getbalance * returned the correct amount that is stored in the wallet and does not actually look at the transaction that isn’t in the mempool or the blockchain, which is whythe output is different from just getbalance…
  • Dumped the transaction in question when accidentally reproduced the issue., The transaction in question is safe because all the inputs are already spent and nothing will happen if the transaction goes into the wild, so it’s possible to test what exactly made it so that it is not able to be accepted in the mempool. Once we fix this, there won’t be any problems like this in the future.
  • zapwallettxes=1 fixes this problem, and no further work is needed. Need to create a wallet with the following settings before importing: usemnemonic=0, usehd=1, upgradewallet=0. usehd=1 works in this case but not usehd=0, a bit counterintuitive

Miscellaneous

  • Electrum-Firo: There is a new release. Gevorg finished all working build processes on Github Actions for all platforms.
  • FiroDex: There are some minor issues to be fixed.
  • MasternodeTool: Gevorg will be looking into an issue reported by Anwar.
2 Likes
55

Week 1 March 2023

Lelantus Spark

  • Levon is testing Spark functionality and did some minor fixes related to rough transaction parsing.
  • The required changes for Spark devnet explorer have been done. There are still small changes to be made to insight-ui-zcoin. Some changes to several repositories supporting devnet for Explorer are needed as it is a new network. This will need 2-3 days to complete.
  • Binaries builtwith GUIX crashes upon reaching Spark batch verification; manually built binaries have no problem.
  • Levon is continuing to test the mobile Spark lib and API in order to complete it by the end of the week.
  • Arcadia has been engaged to assist with the GUI for Spark

getbalance issue

  • Peter continues to try fixing the issue leading to the tx that can’t get into the mempool. He found out the fix was not that easy. It was thought that the test that was done last week was proof that something could happen, but when reproducing the issue, the transaction goes to the mempool normally. It is tricky, as the transaction can’t get to the mempool during the send to RPC call, but it can get into the mempool via the send raw transaction RPC call. This will be addressed and is not a fatal issue, as zapwallettxes=1 will do the trick.
  • He found a way to reproduce the issue by adding several large transactions in quick succession to the mempool. Then there will be an error regarding the “too long mempool chain”. This is a problem when you cannot link too many UTXOs on unconfirmed mempool transactions. There is a way to fix this problem by trying to add the transaction first to the mempool and only then marking the UTXO as spent on the wallet.

Miscellaneous

  • FiroDex: Gevorg finished and is preparing for the 0.5.7 release. AtomicDEX has a .1 release. We might need to open a PR on KomodoPlatform/coins for the lack of a local config file in this new release and some missing Electrumx servers.
  • MasternodeTool: There was some work done on it.
  • Ledger live: Gevorg will be continuing to work on integrating Firo on Ledger live.
8 Likes
56

Week 2 March 2023

Lelantus Spark

  • Devnet Explorer: There was an issue adding a new network to Devnet. Levon and Anwar are figuring out what is wrong with it as they were unable to install it to do tests.
  • There are new unit tests added for Spark, and hopefully the Explorer will be ready for Devnet as most changes have been made.
  • Levon will be doing manual testing for devnet as soon as the explorer issue is resolved.

Getbalance issue

  • Peter found out that there is little we can do since this is actually a feature of Bitcoin (deducts your balance but doesn’t go into the mempool). It is recommended for users to use the command zapwallettxes=1 if there is a discrepancy between getbalance and getbalance *
    • The reason for this issue is that some of the change from the first transaction is used in the second transaction. There’s a limit on the size of transactions in the mempool until one is mined into a block, the second one cannot really enter the mempool, and balance is reduced. It won’t get into the mempool unless rebroadcasted.

Miscellaneous

  • FiroDex: Gevorg has finished preparation for the 0.5.7 release. Anwar has tested it and it works fine on all platforms.
  • MasternodeTool: Support for Nano S Plus was added. Currently fixing blank configuration spaces (passwords, private keys, servers, etc.)
  • Ledger-live: Gevorg continues to work on ledger-live integrations for Firo.
6 Likes
57

Week 3 March 2023

Lelantus Spark

  • Levon is working on fixing issues with devnet Explorer. It is running, but it crashes the whole server when accessing data from the block. This issue is currently being investigated.
  • Levon did some tests on Spark and assisted Arcadia on it too.
  • Peter continues to do testing and research on Spark.

Bitcoin CVEs

  • Peter examined the bitcoin CVEs and found fixes for all four of them. Tests are being done on the last vulnerability. There are some tests failing; however, it is not due to the code but the test itself. A dedicated post we be on Firo’s Blog

Miscellaneous

  • FiroDex: Beta v0.5.7 has been released and is available for download.
  • MasternodeTool: Gevorg continues fixing blank configuration.
  • Ledger-live: Gevorg has done some work on the integration and presented his work to Levon for review.
6 Likes
58

Week 4 March 2023

Lelantus Spark

  • Levon managed to fix all the major issues regarding the Devnet explorer and some failing spark tests. It is currently working however there are some minor UI stuff that need fixing and adding some additional functions.(e.g. show hidden instead of 0, add spark-type addresses to be searchable)
  • Peter did some work on Spark which includes research and code review. This week will be testing Lelantus Spark.

Bitcoin CVEs

  • Peter did some final fixes to the python test that failed. The issue was in the framework.

Miscellaneous

  • FiroDex: The “Update” function within the application which was reported by AJay. Gevorg will be investigating the issue and checking the security concerns about it.
  • Ledger-live: Gevorg continues working on the integrations and finalizing it.
  • MasternodeTool: Gevorg is currently fixing the blank configuration issue
  • Stack mobile: Levon is investigating a recovery issue on Stack mobile wallet. The stack team found the issue faster and notified Levon about it. The issue would break the recovery for firo-qt/electron/mobile. They have a fix for this issue.
8 Likes
59

Week 1 April 2023

Lelantus Spark

  • There is an UI issue with searching Spark-type transactions in the explorer. Levon is nearly done fixing it.
  • Levon is investigating an issue with spending amounts exceeding the limit on Spark.
  • There is a small bug in creating mint transactions, which can be fixed rather quickly. It is planned to remove the Spark mint limits.
  • Peter is looking at the state of Spark by going through the research paper and code. He did some small fixes in the code and reviewed the code.
  • Levon is investigating and fixing the isMine() function bug. This requires several hours of testing.
  • Testing on Devnet and Regtest continues. Testnet deployment will be discussed later in the week.

Firo Client

  • Sproxet is finishing the test for Firo Client upgrades.

Miscellaneous

  • FiroDex: Gevorg is investigating the internal Update function in FiroDex and found out that this issue also happens on AtomicDex.
  • MasternodeTool: Gevorg investigated the blank configurations problem. The previous version of znodetool had no problem with it and took steps to identify the issue.
5 Likes
60

Week 2 April 2023

Lelantus Spark

  • Peter did a code review on Spark that correlates to the white paper and test coverage assessments. So far it is pretty good.
  • Levon finished fixing the isMine() bug. However, it results in some RPC tests failing, which are being fixed.
  • Transaction indexing is fixed, which allows Explorer to lookup Spark-type addresses.
  • Levon edited the mint creation limit to set it to no limit.
  • Levon will be fixing the Spark spend issue where exceeding the maximum limit will result in failed transaction creation due to unoptimized code.
  • Peter had some outstanding PRs regarding refactors, and they will be finished soon.

Firo Client

  • Sproxet is almost finished with the test for Gui-client before moving on to transaction creation.

Miscellaneous

  • Bitcoin IP leak issue: Peter is investigating this. He doesn’t think we have it. However, this is probably a bad thing since we don’t have it. This is because transactions that never get broadcast to the mempool will not be rebroadcast in the future or ever (Daemon).GUI wallets have a function to rebroadcast, but not in daemon.
  • Ledger-live: Gevorg worked on the Firo integration. He will be meeting with Levon later this week to check his code.
5 Likes
61

Week 3 April 2023

Gevorg

  • Ledger-live: Fixed the build issue. To start testing.

Peter

  • worked on the PR to allow resending wallet transactions only once without leaking the sender’s IP address (Bitcoin inherited bug in some edge cases). Had to port some code from Bitcoin 0.24. There are a few tests before pushing the PR.
  • Worked on the PR that supports multiple wallets and increases performance, a prerequisite for the Spark refactor PR.
  • Newer versions of Bitcoin code assumes the possibility of multiple wallets being loaded onto the daemon which Firo does not. This results in some undesired behaviour and crashes during certain RPC calls.
  • Identified and working to improve reindex/wallet scan performance. Identified unnecessary reads and writes to the wallet database file, which impacted the performance for large wallets. Estimated 15-20% speed increase once fixed.
  • Spark: There are minor issues, and will issue a PR regarding the fix by the end of the week.

Levon

  • Spark: Worked on Spark mobile lib. To finalize the documentation for it
  • Spark: To implement unit tests for testing the transaction creation flow for mobile to simulate the process of calling several functions. To cleanup and fix the new unit tests next. 3–4 tests were made, and to continue thinking of new ideas for testing.
  • Assisting the Arcadia team on QT implementation with tests.
  • Ledger-live: Started Gevorg’s ledger live code review.

Minor Spark improvement

  • Sarang proposed a minor change to allow better hardware wallet support in a more adversarial scenario where you are also assuming that the helper device (laptop/mobile) could be compromised and can redirect funds (even though they don’t have access to the spend key)
  • Changes implemented and testing
6 Likes
62

能否让firo client 客户端支持ledger 等硬件钱包，谢谢。

1 Like
63

Firo Dev Text Update May 2023

Week 1

Levon
Last Week:
-Assisting Arcadia
-implementing full API unitest for mobile lib
-adding subtractFeeFromAmount for spark mint creation
-Reviewed #PR1237
This week:
-Cleanup and provide mobile design documents
-Remove spend input number limit
-Change spark address prefix from p to s

Peter
Last week:
-wallet resend PR
-multiple wallets PR (will be completed next week)
-PR regarding minor spark fixes (tmr?)
This week:
-spark, multiple wallets

Gevorg
Last Week:
-(Ledger) Testing
-(Ledger) Fix errors
This Week:
-(Ledger) Continue testing

5 Likes
64

Firo Dev Text update May 2023

Week 2

Levon
Last Week:
-Added subtract fee from amount option for mint creation
-Removed spend number limit and other minor fixes
This Week:
-Continue testing
-Preparing for devnet restart

Peter
Last week:
-minor fixes for the spark
-completion of wallet tx rebroadbast (need testing)
-multiple wallet fix
This week:
-spark testing and fixes

Sproxet
-working on tests for public transaction creation. Found a few bugs. Coverage is coming along. Will then need some adaptation for Spark.

Gevorg
-Still testing and fixing errors
-Finished with bridge now testing account syncing

5 Likes
65

Week 3 May 2023

Lelantus Spark

  • Peter worked on a patch for multiple wallet/improvements for Spark PR. Ideally, the final form of this PR will have only one instance of CwalletDB.
  • Peter reviewed the code regarding Firo-ElectrumX/Electrum-Firo, Sproxet’s, and Levon’s.
  • More PRs regarding wallet refactoring are being done.
  • Levon worked on fixing minor spark issues and failing tests.
  • Peter will be preparing a devnet relaunch the day after this meeting.

Firo-Client

  • Sproxet continues work on transaction creation and undefined behavior issues. There are a couple of tests that need to be done for transaction creation.
  • Sproxet will look into the Masternode Firo Client issue, where it was reported that some masternodes are not displaying on the masternode tab list.

Miscellaneous

  • Ledger-live: Gevorg will be fixing some issues and is nearly done with testing. It will be finalized this week.
6 Likes
66

Week 4 May 2023

Lelantus Spark

  • Devnet was restarted by Peter; the HF (devnet) for Spark is 1500 (the current block value is 877). Any deal-breaking issues must be resolved before the hard fork block because it will otherwise require several components to be reset (mining, masternode, etc.) and is very troublesome.
  • Levon investigates and fixes the spend conflict issues.
  • Spark UI: Levon was investigating and resolving current UI testing issues. Arcadia’s team was notified and reported that the fixes were working. Testing of the UI can begin shortly after.
  • Peter continued work on multi wallet support by the client and also, optimizing Lelantus Spark code by removing unnecessary reads and writes from the disk.
  • Spark QT: Levon started reviewing the changes made to the QT code by Arcadia to support Lelantus Spark, and it will be tested on Devnet this week. If everything goes well, Testnet will be ready to be launched within a week or two.
  • Reviews of GUI code and testing are still ongoing, and Spark Devnet Explorer needs to be updated.
  • Peter worked on a build problem on Fedora (Issue 1240) reported by erciccione, Unfortunately, another problem appeared, and will need to use a virtual machine to test fixes.

Firo

  • Sproxet is finishing up on public transaction creation logic code tests and moving on to the private transaction creation part.

Miscellaneous

  • Ledger-live: Gevorg is continuing work on the integration and finalizing it.
5 Likes
67

Week 4 May 2023

Lelantus Spark

  • Levon reviewed code from Arcadia and assisted in UI implementation.
  • Peter worked on fixing compilation issues. A more recent version of autotools was used. Fixing these issues will avoid problems in future versions of Ubuntu/Debian. The problem lies with the bls-dash library. The build process changed sometime and was incompatible with GUIX. Peter will be pushing a quick fix for Fedora soon and also will need to update the bls library later.
  • Current issues:
  1. Wallet crashes with UI; currently investigating by Levon
  2. Devnet explorer; worked by Levon
  3. Spark QT issues: address book, anonymize all, and crashes
  • Peter will be launching proper quorums on devnet
  • Peter will be working on wallet refactoring and associated syncing issues; PR will be pushed in two separate parts.

Firo

  • Sproxet worked on unifying transaction creation between different types of transactions, so CoinControl will only have one logic to select everything. Other parts of transaction creation besides input selection might have multiple logics, but input selection will be one logic for all types. Unifying transaction creation with abstract-based classes for different types of transaction outputs.

Miscellaneous

  • Ledger-live: Gevorg is finished with the integration and will be meeting Levon to test the code with him.
3 Likes