Weekly Firo Development Meeting Minutes

January 2023

Week 1 January

Getbalance issue

  • Peter is investigating the get balance issue. The issue is the wallet doesn’t allow one to spend funds sometimes. This happens on a really old wallet that was before HD and Mnemonics. There is a dirty fix available but not recommended unless funds are urgently needed.

Lelantus Spark

  • Levon is working on the deadlock issue. This is probably related to devnet explorer crashing.

InstantSend Lock

  • On hold until getbalance issue is solved

Firo Client

  • Sproxet getting work done for light client and updated firo client dependencies (3 years out of date)

Miscellaneous

  • Electrum-Firo: Gevorg checked and tested Dependabot updates
  • Ledger-live: Finalize with ledger
  • FiroDEX: Finalized preparation for new version for release
  • Ubuntu UI: New issue of unable to resize window due to sigma stuff is in the way. Gevorg is working on trying to remove Sigma window from the UI

Week 2 January

Getbalance issue

  • Peter was able to reproduce but there were some kind of issues. Not sure if the reproduced issue is the one that mining pools are encountering. He suspects the main problem is non-HD wallet and its restoration. Trying to repro on regtest, no luck so far. Levon will be assisting however he can

Lelantus Spark

  • Levon continues on the deadlock issue. The issue was found and a fix is working so far. Further testing is still needed.
  • Few python tests and several C++ unit tests were added
  • Works on Spark mobile are still ongoing

Miscellaneous

  • Electrum-firo: Gevorg update python version to 3.8 as there were some problems with dependency on 3.6 when building electrum-firo
  • FiroDEX: Gevorg added local config files and will release new version after testing
  • firo-qt: Gevorg is finishing work on removing sigma dialog from UI. There are some deprecated signals that need to be removed.
  • Ledger-live: Work on Ledger and to be finalized this week.

Week 3 January

Firo

  • Hardfork regarding the extension of Lelantus emergency switch per community decision went smoothly
  • Peter monitored the hardfork transition. There are some nodes that have not been updated. It will be fine as there are no active sporks currently but if they update they will need to reindex
  • There are some performance issues when syncing with wallets that have huge transaction history. To test by starting the wallet with firod (instead of firoqt) when it hasn’t synced for quite awhile. It might be something to do with GUI part of transaction list.

Getbalance issue

  • There are discrepancy between “getbalance” and “getbalance *” RPC calls that are giving incorrect results. Peter did some investigation on testnet and was able to kind of reproduce the results. He suspects the problem is because the wallet is non-HD. Logs were taken from the reindex and UTXO list processed during these calls and analyzed. Hopefully a fix will be found soon.

Lelantus Spark

  • Levon is finished with mobile spark related stuff
  • Deadlock fix is also finished and levon will be doing a cleanup. After that he is to set up explorer for devnet and start with the UI backend implementation.

Miscellaneous

  • Electrum Firo: Gevorg is trying to fix a bug when creating an exe file for Windows. The fix is mostly done but has problems with naming and version. It will be fixed soon
  • Firo-QT: Gevorg finished removing sigma dialog from the UI. He reworked some Lelantus dialog box and will make ui smaller by 100px if approved
  • Ledger: to finalized ledger
  • FiroDEX: Some changes has been made but not yet tested

Week 4 January

Text update from dev team as some devs were unwell to attend meeting

Getbalance issue

  • Peter did a test for UTXOs in the wallet (if they are treated as “ours”) on regtest (non-HD wallet) and testnet (HD wallet). There is one issue and was able to repro it on testnet and a fix is underway.

Lelantus Spark

  • Levon is fixing failing unit test
  • Levon researched Spark explorer and implementation method

Miscellaneous

  • Electrum-Firo: Gevorg worked on electrum-firo build fix
  • Firo-QT: Gevorg is removing sigma dialog from UI and to finalized this week

Week 5 January

Getbalance issue

  • Peter received the wallet from 2miners and found that listed UTXOs that are treated by spendable by getbalance without paramaters and getbalance with * parameters.
  • There are discrepancies between those RPC outputs. He is investigating why this is happening and knowing what might be wrong. Testing has started but a huge wallet is taking 4 to 5 hours to go through. He is optimistic on finding the reason and a fix should be easy if right
  • There might be another problem which was found on testnet with a huge wallet.

Lelantus Spark

  • Levon started working on Devnet explorer implementation and spent most of the time familiarizing with explorer code. Estimated that it will be ready some time this week
  • Levon also investigate failing test on various platform

Firo Mobile

  • There were recovery issues on the Firo mobile wallet that was reported. Upon processing the recovery step 3 out of 5 (downloading set data) the app crashes to the home screen.
  • Levon is currently prioritizing this issue and investigating it

Miscellaneous

  • Electrum-Firo: Gevorg worked on Electrum Firo build fix but ran into some problems with BLS. To solve the issue, python needs to be downgraded to version 3.8. Levon is assisting with this.
  • Firo-QT: Levon reviewed Gevorg changes on removing the sigma UI cleanup
  • A new staff, Narek, joins the meeting for the first time, he has been helping Levon with Spark
2 Likes